Bleep bloop. Greetings hepeng.0320, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author hepeng <[email protected]> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Peng He <[email protected]> WARNING: Line is 99 characters long (recommended limit is 79) #175 FILE: lib/conntrack.c:815: static void do_nat4_src(struct dp_packet *pkt, struct ip_header *inner_l3, const struct conn *conn) WARNING: Line is 99 characters long (recommended limit is 79) #181 FILE: lib/conntrack.c:821: static void do_nat4_dst(struct dp_packet *pkt, struct ip_header *inner_l3, const struct conn *conn) WARNING: Line is 113 characters long (recommended limit is 79) #187 FILE: lib/conntrack.c:827: static void do_nat6_src(struct dp_packet *pkt, struct ovs_16aligned_ip6_hdr *inner_l3_6, const struct conn *conn) WARNING: Line is 113 characters long (recommended limit is 79) #194 FILE: lib/conntrack.c:834: static void do_nat6_dst(struct dp_packet *pkt, struct ovs_16aligned_ip6_hdr *inner_l3_6, const struct conn *conn) WARNING: Line is 101 characters long (recommended limit is 79) #203 FILE: lib/conntrack.c:843: void (*do_nat4)(struct dp_packet *, struct ip_header *, const struct conn *conn)) ERROR: Inappropriate spacing around cast #234 FILE: lib/conntrack.c:858: extract_l3_ipv4(&inner_key, inner_l3, tail - ((char *)inner_l3) - pad, WARNING: Line is 109 characters long (recommended limit is 79) #277 FILE: lib/conntrack.c:874: void (*do_nat6)(struct dp_packet *, struct ovs_16aligned_ip6_hdr *, const struct conn *)) ERROR: Inappropriate spacing around cast #293 FILE: lib/conntrack.c:890: tail - ((char *)inner_l3_6) - pad, WARNING: Line is 96 characters long (recommended limit is 79) #311 FILE: lib/conntrack.c:907: void (*do_nat4)(struct dp_packet *, struct ip_header *, const struct conn *), WARNING: Line is 108 characters long (recommended limit is 79) #312 FILE: lib/conntrack.c:908: void (*do_nat6)(struct dp_packet *, struct ovs_16aligned_ip6_hdr *, const struct conn *)) Lines checked: 348, Warnings: 9, Errors: 3 Please check this out. If you feel there has been an error, please email [email protected] Thanks, 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
