Bleep bloop. Greetings hepeng.0320, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author hepeng <[email protected]> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Peng He <[email protected]> WARNING: Line is 80 characters long (recommended limit is 79) #87 FILE: lib/conntrack.c:152: handle_ftp_ctl_interest(struct conntrack *ct, const struct conn_lookup_ctx *ctx, WARNING: Line is 88 characters long (recommended limit is 79) #133 FILE: lib/conntrack.c:188: static void ftp_ctl_before_hook(struct conntrack *ct, const struct conn_lookup_ctx *ctx, WARNING: Line is 86 characters long (recommended limit is 79) #134 FILE: lib/conntrack.c:189: struct dp_packet *pkt, struct conn *ec, long long now, ERROR: Inappropriate bracing around statement #138 FILE: lib/conntrack.c:193: if (pkt_type == CT_FTP_CTL_INTEREST) WARNING: Line is 87 characters long (recommended limit is 79) #148 FILE: lib/conntrack.c:203: static void ftp_ctl_after_hook(struct conntrack *ct, const struct conn_lookup_ctx *ctx, WARNING: Line is 85 characters long (recommended limit is 79) #149 FILE: lib/conntrack.c:204: struct dp_packet *pkt, struct conn *ec, long long now, ERROR: Inappropriate bracing around statement #153 FILE: lib/conntrack.c:208: if (pkt_type == CT_FTP_CTL_INTEREST) WARNING: Line is 83 characters long (recommended limit is 79) #165 FILE: lib/conntrack.c:220: static void handle_ftp_ctl(struct conntrack *ct, const struct conn_lookup_ctx *ctx, WARNING: Line is 81 characters long (recommended limit is 79) #166 FILE: lib/conntrack.c:221: struct dp_packet *pkt, struct conn *ec, long long now, ERROR: Inappropriate bracing around statement #169 FILE: lib/conntrack.c:224: if (detect_ftp_ctl_type(ctx, pkt) != CT_FTP_CTL_INTEREST) WARNING: Line is 107 characters long (recommended limit is 79) #190 FILE: lib/conntrack.c:245: conn_update_before_hook(enum ct_alg_ctl_type type, struct conntrack *ct, const struct conn_lookup_ctx *ctx, ERROR: Inappropriate bracing around statement #198 FILE: lib/conntrack.c:253: if (alg_helper_hooks[type].before_conn_update_hook) WARNING: Line is 83 characters long (recommended limit is 79) #199 FILE: lib/conntrack.c:254: alg_helper_hooks[type].before_conn_update_hook(ct, ctx, pkt, ec, now, nat); WARNING: Line is 106 characters long (recommended limit is 79) #203 FILE: lib/conntrack.c:258: conn_update_after_hook(enum ct_alg_ctl_type type, struct conntrack *ct, const struct conn_lookup_ctx *ctx, ERROR: Inappropriate bracing around statement #211 FILE: lib/conntrack.c:266: if (alg_helper_hooks[type].after_conn_update_hook) WARNING: Line is 99 characters long (recommended limit is 79) #212 FILE: lib/conntrack.c:267: alg_helper_hooks[type].after_conn_update_hook(ct, ctx, pkt, ec, now, nat, create_new_conn); WARNING: Line is 83 characters long (recommended limit is 79) #226 FILE: lib/conntrack.c:281: alg_helper_hooks[ct_alg_ctl].alg_helper_hook(ct, ctx, pkt, conn, now, nat); ERROR: Inappropriate bracing around statement #311 FILE: lib/conntrack.c:789: if (type == CT_ALG_CTL_NONE) WARNING: Line is 89 characters long (recommended limit is 79) #316 FILE: lib/conntrack.c:794: this case helper_type is not NONE, however type is not consisted with helper_type ERROR: Inappropriate bracing around statement #321 FILE: lib/conntrack.c:799: else ERROR: Inappropriate bracing around statement #384 FILE: lib/conntrack.c:1098: if (OVS_UNLIKELY(conn->conn_flags & CONN_FLAG_CTL_FTP)) ERROR: Inappropriate bracing around statement #387 FILE: lib/conntrack.c:1101: if (OVS_UNLIKELY(conn->conn_flags & CONN_FLAG_CTL_TFTP)) WARNING: Line is 88 characters long (recommended limit is 79) #469 FILE: lib/conntrack.c:1405: conn_update_before_hook(ct_alg_ctl, ct, ctx, pkt, conn, now, !!nat_action_info); WARNING: Line is 104 characters long (recommended limit is 79) #471 FILE: lib/conntrack.c:1407: conn_update_after_hook(ct_alg_ctl, ct, ctx, pkt, conn, now, !!nat_action_info, create_new_conn); ERROR: Inappropriate bracing around statement #516 FILE: lib/conntrack.c:2544: if (conn->conn_flags & CONN_FLAG_CTL_FTP) ERROR: Inappropriate bracing around statement #518 FILE: lib/conntrack.c:2546: if (conn->conn_flags & CONN_FLAG_CTL_TFTP) WARNING: Line is 80 characters long (recommended limit is 79) #545 FILE: lib/conntrack.c:3281: handle_ftp_ctl_interest(struct conntrack *ct, const struct conn_lookup_ctx *ctx, WARNING: Line is 88 characters long (recommended limit is 79) #685 FILE: lib/conntrack.c:3377: handle_ftp_ctl_other(struct conntrack *ct OVS_UNUSED, const struct conn_lookup_ctx *ctx, WARNING: Line is 86 characters long (recommended limit is 79) #686 FILE: lib/conntrack.c:3378: struct dp_packet *pkt, struct conn *ec, long long now OVS_UNUSED, WARNING: Line is 82 characters long (recommended limit is 79) #700 FILE: lib/conntrack.c:3392: th->tcp_csum = packet_csum_upperlayer6(nh6, th, ctx->key.nw_proto, Lines checked: 727, Warnings: 20, Errors: 12 Please check this out. If you feel there has been an error, please email [email protected] Thanks, 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
