Hello Ian, On Tue, Dec 1, 2020 at 9:14 PM Stokes, Ian <[email protected]> wrote: > > A small note: $HOME is world writable in GHA envs, this triggers a > > dpdk init failure when loading a plugin from a path under $HOME (EAL > > has a runtime check on o-w permissions for loaded binaries). > > My workaround with GHA for dpdk to chmod o-w $HOME, but I did not see > > any issue for OVS, since no plugin is loaded in the CI. > > > > Just to clarify here David, are you saying that there isn't currently an > issue (i.e. it could potentially happen) but you haven’t seen it?
I had not tried to reproduce the issue but it should happen with dpdk shared builds that we don't test in OVS jobs: https://github.com/openvswitch/ovs/blob/master/.github/workflows/build-and-test.yml#L92 The workaround is to add a chmod o-w $HOME. Example for dpdk: https://github.com/ovsrobot/dpdk/commit/c5e1ca36202839e60d0258942c86eef22314e679#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721R73 [snip] > > So we need an updated packages list in GHA. > > And meson is not found for a user-only install unless updating PATH. > > Thanks for flagging, and providing the patch below, I've rolled this into the > v2. [snip] > > @@ -146,7 +147,7 @@ jobs: > > run: ./.ci/linux-prepare.sh > > > > - name: build > > - run: PATH="$PATH:$HOME/bin" ./.ci/linux-build.sh > > + run: PATH="$PATH:$HOME/bin:$HOME/.local/bin" ./.ci/linux-build.sh > > Out of interest, is this the workaround you’ve 'referenced for using $HOME > earlier in your response? This is for user-only installed meson to be available. -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
