> -----Original Message-----
> From: Stokes, Ian <[email protected]>
> Sent: Monday 7 December 2020 16:32
> To: Finn, Emma <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: RE: [PATCH] netdev-offload-dpdk: Reverting Temporary patch to fix
> broken hardware offload ethernet matching for XL710 NICs.
>
> > Removing temporary patch - 023f257 (netdev-offload-dpdk: Fix for
> > broken ethernet matching HWOL for XL710NIC).
> > Ethernet pattern is now being set correctly withtin the i40e PMD.
> >
> > Signed-off-by: Emma Finn <[email protected]>
>
> Thanks for the patch Emma.
>
> I think this has a dependency on moving to DPDK 20.11 if I'm correct? As such
> we should hold off applying until then?
The fix was backported to DPDK 19.11. But we can hold off until 20.11 if we
want.
Thanks,
Emma
>
> Regards
> Ian
> > ---
> > lib/netdev-offload-dpdk.c | 15 +--------------
> > 1 file changed, 1 insertion(+), 14 deletions(-)
> >
> > diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
> > index 01c52e1..916f42b 100644
> > --- a/lib/netdev-offload-dpdk.c
> > +++ b/lib/netdev-offload-dpdk.c
> > @@ -695,20 +695,7 @@ parse_flow_match(struct flow_patterns *patterns,
> > consumed_masks->packet_type = 0;
> >
> > /* Eth */
> > - if (match->wc.masks.dl_type == OVS_BE16_MAX && is_ip_any(&match-
> > >flow)
> > - && eth_addr_is_zero(match->wc.masks.dl_dst)
> > - && eth_addr_is_zero(match->wc.masks.dl_src)) {
> > - /*
> > - * This is a temporary work around to fix ethernet pattern for
> > partial
> > - * hardware offload for X710 devices. This fix will be reverted
> > once
> > - * the issue is fixed within the i40e PMD driver.
> > - */
> > - add_flow_pattern(patterns, RTE_FLOW_ITEM_TYPE_ETH, NULL, NULL);
> > -
> > - memset(&consumed_masks->dl_dst, 0, sizeof consumed_masks-
> >dl_dst);
> > - memset(&consumed_masks->dl_src, 0, sizeof consumed_masks-
> >dl_src);
> > - consumed_masks->dl_type = 0;
> > - } else if (match->wc.masks.dl_type ||
> > + if (match->wc.masks.dl_type ||
> > !eth_addr_is_zero(match->wc.masks.dl_src) ||
> > !eth_addr_is_zero(match->wc.masks.dl_dst)) {
> > struct rte_flow_item_eth *spec, *mask;
> > --
> > 2.7.4
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
