On 12/23/20 7:08 PM, Lorenzo Bianconi wrote: > Fix the following ovn-trace warning triggered by controller_event: > > 00001|ovntrace|WARN|trigger_event(event = "empty_lb_backends", meter = "", > vip = "192.168.0.100:80", protocol = "tcp", > load_balancer = > "2c5462a7-b6ca-4b02-86c9-b9aa98a570e8"); > parsing actions failed (Syntax error a t `vip' expecting empty_lb_backends > option name.) > > The issue can be triggered running the following reproducer in ovn-sanbox: > > $./ovn-setup.sh > $ovn-nbctl lb-add lb0 192.168.0.100:80 "" > $ovn-nbctl ls-lb-add sw0 lb0 > $ovn-nbctl --wait=hv set NB_Global . options:controller_event=true > $ovn-trace sw0 'inport == "sw0-port1" && eth.src == 50:54:00:00:00:01 && > ip4.src==192.168.0.2 && eth.dst == 00:00:00:00:ff:01 && > ip4.dst==192.168.0.100 && tcp && tcp.dst==80' > > Signed-off-by: Lorenzo Bianconi <[email protected]> > ---
Looks good to me, however it would be nice to have a unit test to avoid future breakages. Nevertheless: Acked-by: Dumitru Ceara <[email protected]> Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
