On 12/22/20 4:48 PM, Eelco Chaudron wrote: > > > On 22 Dec 2020, at 16:16, Paolo Valerio wrote: > >> Eelco Chaudron <[email protected]> writes: >> >>> When you would like to add, modify, or delete a lot of flows in the >>> datapath, for example when you want to measure performance, adding >>> one flow at the time won't scale. This as it takes a decent amount >>> of time to set up the datapath connection. >>> >>> This new command is in-line with the same command available in >>> ovs-ofctl which allows the same thing, with the only difference that >>> we do not verify all lines before we start execution. This allows for >>> a continuous add/delete stream. For example with a command like this: >>> >>> python3 -c 'while True: >>> for i in range(0, 1000): >>> print("add in_port(0),eth(),eth_type(0x800),ipv4(src=100.1.{}.{}) >>> 1".format(int(i / 256), i % 256)) >>> for i in range(0, 1000): >>> print("delete >>> in_port(0),eth(),eth_type(0x800),ipv4(src=100.1.{}.{})".format(int(i / >>> 256), i % 256))' \ >>> | sudo utilities/ovs-dpctl add-flows - >>> >>> >>> Signed-off-by: Eelco Chaudron <[email protected]> >>> --- >>> v3: - Fixed NEWS section >>> - Added/update mod-flows/del-flows command to support FILE input >>> - Added some selftests >>> v2: - Added change to NEWS >>> - Updated man page to be more clear >>> >>> NEWS | 3 + >>> lib/dpctl.c | 195 >>> ++++++++++++++++++++++++++++++++++++++++++++----- >>> lib/dpctl.man | 16 ++++ >>> tests/dpctl.at | 50 +++++++++++++ >>> utilities/ovs-dpctl.c | 10 ++- >>> 5 files changed, 251 insertions(+), 23 deletions(-) >>> >>> diff --git a/NEWS b/NEWS >>> index 4619e73bf..fed222765 100644 >>> --- a/NEWS >>> +++ b/NEWS >>> @@ -7,6 +7,9 @@ Post-v2.14.0 >>> * Removed support for vhost-user dequeue zero-copy. >>> - The environment variable OVS_UNBOUND_CONF, if set, is now used >>> as the DNS resolver's (unbound) configuration file. >>> + - ovs-dpctl and 'ovs-appctl dpctl/': >>> + * New commands where added, which allow adding, deleting, or modifying >>> + flows based on information read from a file. >>> >> >> Tested it successfully. > > Thanks Paolo! > >> NEWS has conflicts, besides that, it would be nice to add the commands >> ({add,mod,del}-flows) explicitly in the description for consistency with >> the other dpctl entries. > > Guess you mean in the NEWS file itself, like: > > + - ‘ovs-dpctl {add,mod,del}-flows’ and 'ovs-appctl > dpctl/{add,mod,del}-flows': > + * New commands were added, which allow adding, deleting, or modifying > + flows based on information read from a file. > > Ilya let me know if you need a new revision if this is all that needs > changing?
No need for a new version. I slightly modified this text, though. > >> Otherwise, >> >> Acked-by: Paolo Valerio <[email protected]> Thanks! Applied. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
