Hi Eli, On Mon, Dec 28, 2020 at 11:43 PM Eli Britstein <[email protected]> wrote: > > Netdev datapath offloads are done in a separate thread, using messaging > between the threads. With port removal there is a race between the offload > thread removing the offloaded rules and the actual port removal, so some > rules will not be removed.
Can you provide details on this sequence, to get more clarity on how some rules will not be removed ? > In OVS the offload objects are not freed (memory > leak). Since dp_netdev_free_flow_offload() frees the offload object, not sure how the memory leak happens ? > In HW the remining of the rules depend on PMD behavior. A few related questions: 1. In Patch-1, netdev_flow_flush() is called from do_del_port(). Doesn't it violate the layering rules, since port deletion shouldn't be directly involved with netdev/flow related operations (that would otherwise be processed as a part of datapath reconfig) ? 2. Since the rte_flow is deleted first, doesn't it leave the dpif_netdev_flow in an inconsistent state, since the flow is still active from the pmd thread's perspective (megaflow_to_mark and mark_to_flow cmap entries are still valid, indicating that it is offloaded). 3. Also, how does this work with partially offloaded flows (same megaflow mapped to multiple pmd threads) ? Thanks, -Harsha > This patch-set resolves this issue using flush. > > v2-v1: > - Fix for pending offload requests. > v3-v2: > - Rebase. > > Travis: > v1: https://travis-ci.org/github/elibritstein/OVS/builds/747022942 > v2: https://travis-ci.org/github/elibritstein/OVS/builds/748788786 > v3: https://travis-ci.org/github/elibritstein/OVS/builds/751787939 > > GitHub Actions: > v1: https://github.com/elibritstein/OVS/actions/runs/394296553 > v2: https://github.com/elibritstein/OVS/actions/runs/413379295 > v3: https://github.com/elibritstein/OVS/actions/runs/448541155 > > Eli Britstein (4): > dpif-netdev: Flush offload rules upon port deletion > netdev-offload-dpdk: Keep netdev in offload object > netdev-offload-dpdk: Refactor disassociate and flow destroy > netdev-offload-dpdk: Implement flow flush > > lib/dpif-netdev.c | 2 + > lib/netdev-offload-dpdk.c | 85 +++++++++++++++++++++++++-------------- > 2 files changed, 56 insertions(+), 31 deletions(-) > > -- > 2.28.0.546.g385c171 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
