Looks good to me.

Acked-by: Mark Michelson <[email protected]>

On 1/11/21 7:06 AM, Dumitru Ceara wrote:
This series adds support to ovn-controller to notify northd that all OVS
flows and OVS interface corresponding to an OVN logical port have been
installed in OVS.

The series extends the ofctrl barrier implementation and makes it generic
so that multiple modules can use it.  For now these are:
- main ovn-controller for nb_cfg propagation.
- binding module for marking Port_Bindings as installed.

V3:
- Address Mark's comments:
   - Patch2:
     - Remove unnecessary ENABLE_UNIT_TESTS.
   - Patch3:
     - Add test to check that the ovn-installed external-id is propagated to
       OVS.  The test also checks that the SB Port_Binding.up and
       NB.Logical_Switch_Port.up fields are properly set.
- Patch3:
   - Improve the checks in binding_seqno_install() to cleanup stale bindings
     early.
V2:
- Patch 3:
   - Fix check in binding_seqno_install() to take into account deleted
     port bindings.

Dumitru Ceara (3):
       ofctrl: Rename 'nb_cfg' to 'req_cfg'.
       controller: Implement a generic barrier based on ofctrl cur_cfg sync.
       binding: Set Logical_Switch_Port.up when all OVS flows are installed.


  NEWS                           |    6 +
  controller/automake.mk         |    2
  controller/binding.c           |  181 ++++++++++++++++++++++++++++++
  controller/binding.h           |    5 +
  controller/ofctrl-seqno.c      |  245 ++++++++++++++++++++++++++++++++++++++++
  controller/ofctrl-seqno.h      |   50 ++++++++
  controller/ofctrl.c            |   70 ++++++-----
  controller/ofctrl.h            |    4 -
  controller/ovn-controller.c    |   53 +++++++--
  controller/test-ofctrl-seqno.c |  194 ++++++++++++++++++++++++++++++++
  northd/ovn-northd.c            |    4 -
  ovn-sb.ovsschema               |    5 -
  ovn-sb.xml                     |    8 +
  tests/automake.mk              |    8 +
  tests/ovn-ofctrl-seqno.at      |  226 +++++++++++++++++++++++++++++++++++++
  tests/ovn.at                   |   32 +++++
  tests/testsuite.at             |    1
  utilities/ovn-sbctl.c          |    4 +
  18 files changed, 1046 insertions(+), 52 deletions(-)
  create mode 100644 controller/ofctrl-seqno.c
  create mode 100644 controller/ofctrl-seqno.h
  create mode 100644 controller/test-ofctrl-seqno.c
  create mode 100644 tests/ovn-ofctrl-seqno.at

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to