On 13 Jan 2021, at 2:37, Chris Mi wrote:
On 1/13/2021 3:34 AM, Eelco Chaudron wrote:
On 15 Dec 2020, at 4:38, Chris Mi wrote:
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi <[email protected]>
Reviewed-by: Eli Britstein <[email protected]>
---
utilities/ovs-kmod-ctl.in | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/utilities/ovs-kmod-ctl.in b/utilities/ovs-kmod-ctl.in
index 19f100964..6fa945a83 100644
--- a/utilities/ovs-kmod-ctl.in
+++ b/utilities/ovs-kmod-ctl.in
@@ -28,6 +28,14 @@ for dir in "$sbindir" "$bindir" /sbin /bin
/usr/sbin /usr/bin; do
done
insert_mods () {
+ # Try loading psample kernel module.
+ modinfo psample > /dev/null 2>&1
+ if test $? = 0; then
+ action "Inserting psample module" modprobe psample
+ else
+ log_warning_msg "No psample module, can't offload
sFlow action"
+ fi
+
I don't think we need to load psample here, it will be automatically
loaded if we add the sample action. Same as for vxlan, gre, etc.,
etc.
Actually it's a little different. We need to initialize the psample
netlink family and multicast group
when starting ovs daemon. If psample module is not loaded, we'll fail
to initialize them.
You are right something was wrong with my setup causing it to load
through a different way…
I did a bit more experimenting, and this patch is needed and looks fine,
so
Acked-by: Eelco Chaudron <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
