On 1/20/21 10:10 PM, Mark Michelson wrote:
> OVN developers have had isssues with the current method by which OVS
> source code is used by OVN.
> 
> * There is no way to record the minimum commit/version of OVS to use
>   when compiling OVN.
> * When debugging issues, bisecting OVN commits may also requires
>   simultaneously changing OVS commits. This makes for multiple moving
>   targets to try to track.
> * Performance improvements made to OVS libraries and OVSDB may benefit
>   OVN. However, there's no way to encourage the use of the improved OVS
>   source.
> 
> By using a submodule, it allows for OVN to record a specific commit of
> OVS that is expected to be used.
> 
> Signed-off-by: Mark Michelson <[email protected]>
> ---
>  .gitmodules                             |  3 +++
>  Documentation/intro/install/general.rst | 19 ++++++++++++++++---
>  Makefile.am                             | 20 ++++++++++----------
>  acinclude.m4                            |  2 +-
>  build-aux/initial-tab-whitelist         |  1 +
>  ovs                                     |  1 +
>  6 files changed, 32 insertions(+), 14 deletions(-)
>  create mode 100644 .gitmodules
>  create mode 160000 ovs
> 

For some reason this patch broke OSX build:

  The following files are in git but not the distribution:
  ovs
  make[1]: *** [dist-hook-git] Error 1
  make: *** [all] Error 2

Caught by ovsrobot:
  
https://github.com/ovsrobot/ovn/runs/1738128420?check_suite_focus=true#step:5:2998

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to