On 1/25/21 10:10 PM, Anton Ivanov wrote:

[...]

+            atomic_store_relaxed(&control->finished, true);
+            atomic_thread_fence(memory_order_acq_rel);

Especially this seems error prone and it would be better if it's implemented inside fasthmap.c where we actually read &control->finished.

That's a different thread :) You cannot read it there.


I meant inside the fasthmap.c file, not in the function where we read the variable :) Sorry for the confusion.


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to