On Tue, Jan 26, 2021 at 2:02 AM Dumitru Ceara <[email protected]> wrote: > > On 1/25/21 7:39 PM, Mark Michelson wrote: > > OVN developers have had isssues with the current method by which OVS > > source code is used by OVN. > > > > * There is no way to record the minimum commit/version of OVS to use > > when compiling OVN. > > * When debugging issues, bisecting OVN commits may also requires > > simultaneously changing OVS commits. This makes for multiple moving > > targets to try to track. > > * Performance improvements made to OVS libraries and OVSDB may benefit > > OVN. However, there's no way to encourage the use of the improved OVS > > source. > > > > By using a submodule, it allows for OVN to record a specific commit of > > OVS that is expected to be used. > > > > Signed-off-by: Mark Michelson <[email protected]> > > --- > > This looks good to me, thanks! > > Acked-by: Dumitru Ceara <[email protected]>
LGTM too. Acked-by: Numan Siddique <[email protected]> We would definitely need another job in CI to test with OVS master. That can be a follow up patch. Thanks Numan > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
