Bleep bloop. Greetings Anton Ivanov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#240 FILE: lib/parallel-hmap.c:189:
ovs_thread_create("worker pool helper", start,
&new_pool->controls[i]);
ERROR: Inappropriate spacing around cast
#406 FILE: lib/parallel-hmap.c:355:
struct hmap *result = (struct hmap *)fin_result;
ERROR: Inappropriate spacing around cast
#407 FILE: lib/parallel-hmap.c:356:
struct hmap *res_frags = (struct hmap *)result_frags;
ERROR: Inappropriate spacing around cast
#430 FILE: lib/parallel-hmap.c:379:
struct ovs_list *result = (struct ovs_list *)fin_result;
ERROR: Inappropriate spacing around cast
#431 FILE: lib/parallel-hmap.c:380:
struct ovs_list *res_frags = (struct ovs_list *)result_frags;
ERROR: Improper whitespace around control block
#515 FILE: lib/parallel-hmap.h:48:
#define HMAP_FOR_EACH_IN_PARALLEL(NODE, MEMBER, JOBID, HMAP) \
WARNING: Line is 80 characters long (recommended limit is 79)
#597 FILE: lib/parallel-hmap.h:130:
void *fin_result, void *result_frags,
WARNING: Line has trailing whitespace
#691 FILE: lib/parallel-hmap.h:224:
hrl->row_locks = NULL;
Lines checked: 708, Warnings: 3, Errors: 5
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev