From: Yunjian Wang <[email protected]>
Before info.tc_modify_flow_deleted is assigned a value, error
processing of other statements goes to the out label. In the
out label, the uninitialized variant is used for condition
determination, which may cause uncertain behavior.
Fixes: 65b84d4a32bd ("dpif-netlink: avoid netlink modify flow put op failed
after tc modify flow put op failed.")
Signed-off-by: lvmengfan <[email protected]>
Signed-off-by: Yunjian Wang <[email protected]>
---
lib/dpif-netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index ceb56c685..50520f8c0 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -2061,6 +2061,7 @@ parse_flow_put(struct dpif_netlink *dpif, struct
dpif_flow_put *put)
uint8_t csum_on = false;
int err;
+ info.tc_modify_flow_deleted = false;
if (put->flags & DPIF_FP_PROBE) {
return EOPNOTSUPP;
}
@@ -2105,7 +2106,6 @@ parse_flow_put(struct dpif_netlink *dpif, struct
dpif_flow_put *put)
info.tunnel_csum_on = csum_on;
info.recirc_id_shared_with_tc = (dpif->user_features
& OVS_DP_F_TC_RECIRC_SHARING);
- info.tc_modify_flow_deleted = false;
err = netdev_flow_put(dev, &match,
CONST_CAST(struct nlattr *, put->actions),
put->actions_len,
--
2.23.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
