In OVS DPDK (for tap in lib/netdev-linux.c), we don't use net_tap, internal type is also tap type in OVS DPDK use case, that means all the bridge ports (i.e. br-int, ovs-netdev, br-phy, etc.) are tap, it will result in deadlock if we use PMDs to handle them.
For non-bridge tap ports, PMD is much better than ovs-vswitchd, ovs DPDK has support that, you just add tap by vdev (if tap has been created, it will be opened), but if existing tap is in network namespace, it can't be handle. A patch I sent before added netns option, that can fix this issue. TSO-related code in linux/netdev-linux.c can be ported into DPDK net-tap pmd driver, it is very easy. -----邮件原件----- 发件人: William Tu [mailto:u9012...@gmail.com] 发送时间: 2021年2月7日 0:16 收件人: Yi Yang (杨燚)-云服务集团 <yangy...@inspur.com> 抄送: i.maxim...@ovn.org; f...@sysclose.org; yang_y...@163.com; ovs-dev@openvswitch.org; olivier.m...@6wind.com 主题: Re: [ovs-dev] 答复: 答复: [PATCH] netdev-dpdk: fix incorrect shinfo initialization On Mon, Feb 1, 2021 at 5:48 PM Yi Yang (杨燚)-云服务集团 <yangy...@inspur.com> wrote: > > Thanks Ilya, net_tap PMD is handling tap device on host side, so it can > leverage vnet header to do TSO/GSO, maybe net_pmd authors don't know how to > do this, from source code, tap fd isn't enabled vnet header and TSO. > thanks, learned a lot from these discussions. I looked at the DPDK net_tap and indeed it doesn't support virtio net hdr. Do you guys think it makes sense to add TSO at dpdk net_tap? Or simply using the current OVS's userspace-enable-tso on tap/veth is good enough? (using type=system, not using dpdk port type on tap/veth.) Regards, William _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
