Bleep bloop. Greetings gmingchen(陈供明), I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#103 FILE: lib/expr.c:1050:
if(IP_R_DATA->used >= IP_R_DATA->size){ \
WARNING: Line is 89 characters long (recommended limit is 79)
ERROR: Use xrealloc() in place of realloc()
#104 FILE: lib/expr.c:1051:
IP_R_DATA->ip = realloc(IP_R_DATA->ip, 2 * IP_R_DATA->size *
sizeof(uint32_t)); \
WARNING: Line is 93 characters long (recommended limit is 79)
ERROR: Use xrealloc() in place of realloc()
#105 FILE: lib/expr.c:1052:
IP_R_DATA->mask = realloc(IP_R_DATA->mask, 2 * IP_R_DATA->size *
sizeof(uint32_t)); \
WARNING: Line is 93 characters long (recommended limit is 79)
ERROR: Use xrealloc() in place of realloc()
#106 FILE: lib/expr.c:1053:
IP_R_DATA->masked = realloc(IP_R_DATA->masked, 2 * IP_R_DATA->size *
sizeof(bool)); \
ERROR: Use xmalloc() in place of malloc()
#120 FILE: lib/expr.c:1067:
ip_r_data->ip = malloc(4 * sizeof(uint32_t));
ERROR: Use xmalloc() in place of malloc()
#121 FILE: lib/expr.c:1068:
ip_r_data->mask = malloc(4 * sizeof(uint32_t));
ERROR: Use xmalloc() in place of malloc()
#122 FILE: lib/expr.c:1069:
ip_r_data->masked = malloc(4 * sizeof(bool));
ERROR: Improper whitespace around control block
#125 FILE: lib/expr.c:1072:
while(i < ip_data->size){
ERROR: Improper whitespace around control block
#126 FILE: lib/expr.c:1073:
if(i + 1 >= ip_data->size){
WARNING: Line lacks whitespace around operator
#130 FILE: lib/expr.c:1077:
diff = ip_data->ip[i+1] - ip_data->ip[i];
ERROR: Improper whitespace around control block
#132 FILE: lib/expr.c:1079:
if(0 == diff){
ERROR: Improper whitespace around control block
WARNING: Line lacks whitespace around operator
#137 FILE: lib/expr.c:1084:
if((diff & (diff-1)) == 0){
ERROR: Improper whitespace around control block
#139 FILE: lib/expr.c:1086:
if(0 == recorded){
WARNING: Line lacks whitespace around operator
#140 FILE: lib/expr.c:1087:
connect = ip_data->ip[i+1] ^ ip_data->ip[i];
ERROR: Improper whitespace around control block
WARNING: Line lacks whitespace around operator
#142 FILE: lib/expr.c:1089:
if(0 == (connect & (connect-1))){
WARNING: Line is 96 characters long (recommended limit is 79)
#150 FILE: lib/expr.c:1097:
/*The first non-zero place in the high direction is the end
of the segment*/
ERROR: Improper whitespace around control block
#151 FILE: lib/expr.c:1098:
while(j < 32 && (0 == (start & (mask_base << j)))){
ERROR: Improper whitespace around control block
WARNING: Line lacks whitespace around operator
#173 FILE: lib/expr.c:1120:
if(ip_data->ip[i+1] > end){
ERROR: Improper whitespace around control block
#175 FILE: lib/expr.c:1122:
while(continuous_size){
ERROR: Improper whitespace around control block
#179 FILE: lib/expr.c:1126:
if(0 == continuous_size){
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#184 FILE: lib/expr.c:1131:
ERROR: Improper whitespace around control block
#185 FILE: lib/expr.c:1132:
if(0 == mask_base){
WARNING: Line is 101 characters long (recommended limit is 79)
#191 FILE: lib/expr.c:1138:
ip_r_data->mask[ip_r_data->used] = ~(((1 <<
segment_power) - 1) << pow_base);
WARNING: Line is 122 characters long (recommended limit is 79)
WARNING: Line has trailing whitespace
#192 FILE: lib/expr.c:1139:
ip_r_data->ip[ip_r_data->used] =
ip_r_data->mask[ip_r_data->used] & start;
WARNING: Line is 103 characters long (recommended limit is 79)
#197 FILE: lib/expr.c:1144:
start = ip_r_data->ip[ip_r_data->used - 1] + (1 <<
(segment_power + pow_base));
ERROR: Improper whitespace around control block
#211 FILE: lib/expr.c:1158:
if(recorded){
ERROR: Improper whitespace around control block
#213 FILE: lib/expr.c:1160:
while(continuous_size){
ERROR: Improper whitespace around control block
#217 FILE: lib/expr.c:1164:
if(0 == continuous_size){
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#222 FILE: lib/expr.c:1169:
ERROR: Improper whitespace around control block
#223 FILE: lib/expr.c:1170:
if(0 == mask_base){
WARNING: Line has trailing whitespace
#227 FILE: lib/expr.c:1174:
}
WARNING: Line is 97 characters long (recommended limit is 79)
#229 FILE: lib/expr.c:1176:
ip_r_data->mask[ip_r_data->used] = ~(((1 << segment_power)
- 1) << pow_base);
WARNING: Line is 94 characters long (recommended limit is 79)
#230 FILE: lib/expr.c:1177:
ip_r_data->ip[ip_r_data->used] =
ip_r_data->mask[ip_r_data->used] & start;
WARNING: Line is 99 characters long (recommended limit is 79)
#235 FILE: lib/expr.c:1182:
start = ip_r_data->ip[ip_r_data->used - 1] + (1 <<
(segment_power + pow_base));
WARNING: Empty return followed by brace, consider omitting
#253 FILE: lib/expr.c:1200:
}
WARNING: Line is 89 characters long (recommended limit is 79)
ERROR: Improper whitespace around control block
#284 FILE: lib/expr.c:1243:
} else if(lex.token.type == LEX_T_INTEGER && lex.token.format ==
LEX_F_IPV4){
ERROR: Improper whitespace around control block
#294 FILE: lib/expr.c:1265:
if(ip_data.size > 0){
ERROR: Inappropriate bracing around statement
#297 FILE: lib/expr.c:1268:
for (int i = 0; i < ip_r_data.used; ++i)
Lines checked: 711, Warnings: 23, Errors: 25
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
