On 3/17/2021 10:48 AM, Ivan Malov wrote:
External email: Use caution opening links or attachments
Hi Eli,
On 17/03/2021 09:35, Eli Britstein wrote:
+ parse_tcp_flags(packet);
+ if (vport_netdev->netdev_class->pop_header(packet) == NULL) {
Thank you for revising the patch series. As far as I can see, in the new
revision (patch [06/14]), parsing TCP flags is done after successful
miss recovery (which yields a decapsulated packet), and that should be
fairly correct. However, why also call parse_tcp_flags() over here,
before popping the header? This invocation doesn't make use of the
returned value...
Yes, we don't need the returned value here, but parse_tcp_flags also
sets the packet layer offsets.
In the pop_header function, for example netdev_vxlan_pop_header in
lib/netdev-native-tnl.c, it needs the offsets to be valid:
ovs_assert(packet->l3_ofs > 0);
ovs_assert(packet->l4_ofs > 0);
(Sorry if I simply misread the code).
--
Ivan M
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
