On Tue, Mar 09, 2021 at 01:54:08PM -0800, Ben Pfaff wrote: > On Thu, Mar 04, 2021 at 10:15:47AM -0800, Ben Pfaff wrote: > > On Thu, Mar 04, 2021 at 06:07:42PM +0530, Numan Siddique wrote: > > > On Thu, Mar 4, 2021 at 9:40 AM Ben Pfaff <[email protected]> wrote: > > > Thanks for this series. > > > > > > Acked-by: Numan Siddique <[email protected]> > > > > > > Please note that I'm still learning ddlog and haven't understood much > > > of the northd ddlog code. > > > > > > I ran the patches and found a few northd-ddlog tests to be failing > > > when run with -j5. If I run individually they pass. > > > May be the scale improvements in northd-ddlog could help in those tests. > > > > > > I found one particular test failing 100% of the time. > > > > > > Can you please take a look into that. > > > > Thanks for all the comments. I'm looking into this stuff now. > > I pushed the following three commits: > > * "tests: Improve synchronization and debuggability." > * "ovs-sandbox: Make it possible to disable recording ddlog input." > * "ovn-northd-ddlog: Add profiling support." > > I fixed a problem in "ovn-northd-ddlog: Apply multiple database updates > in single ddlog txn.", which was leading to the failures you noticed. > I'll put the fix in v2.
The fix is really solid in my testing, so I decided to just push this series given that I have a new series of improvements that I want to post and making it a much longer series is going to make review difficult. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
