Hi Ben,
I have some comments on the individual patches. In general though, it
seems like 0-day robot has some issues regarding guidelines. You can
probably ignore the warnings about "xxx" comments being present, but the
others looked legitimate to me.
On 3/25/21 7:26 PM, Ben Pfaff wrote:
A daemon mode for ovn-sbctl can make benchmarks much faster. For me,
it made the benchmark provided by Numan drop from several minutes to
about 100 seconds (without ddlog) in one case. I do not know whether
it will make real use of ovn faster, but it's definitely useful if
you want to run tests.
Ben Pfaff (3):
ovn-nbctl: Improve manpage.
ovn-nbctl: Refactor into infrastructure and northbound details.
ovn-sbctl: Add daemon support.
NEWS | 2 +
manpages.mk | 17 -
tests/ovn-sbctl.at | 76 ++-
utilities/automake.mk | 12 +-
utilities/ovn-dbctl.c | 1227 +++++++++++++++++++++++++++++++++
utilities/ovn-dbctl.h | 61 ++
utilities/ovn-nbctl.8.xml | 670 ++++++++++--------
utilities/ovn-nbctl.c | 1363 ++++---------------------------------
utilities/ovn-sbctl.8.in | 317 ---------
utilities/ovn-sbctl.8.xml | 583 ++++++++++++++++
utilities/ovn-sbctl.c | 670 ++++--------------
11 files changed, 2582 insertions(+), 2416 deletions(-)
create mode 100644 utilities/ovn-dbctl.c
create mode 100644 utilities/ovn-dbctl.h
delete mode 100644 utilities/ovn-sbctl.8.in
create mode 100644 utilities/ovn-sbctl.8.xml
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev