On 30/03/2021 10:59, Eelco Chaudron wrote: > I will review the full set in a bit, but I noticed some flake8 errors > when building: > > mv tests/system-tso-testsuite.tmp tests/system-tso-testsuite > ipsec/ovs-monitor-ipsec.in:588:80: E501 line too long (80 > 79 > characters) > ipsec/ovs-monitor-ipsec.in:1194:1: E302 expected 2 blank lines, found 1 > ipsec/ovs-monitor-ipsec.in:1201:1: E302 expected 2 blank lines, found 1 > ipsec/ovs-monitor-ipsec.in:1208:1: E302 expected 2 blank lines, found 1 > ipsec/ovs-monitor-ipsec.in:1216:1: E302 expected 2 blank lines, found 1 > ipsec/ovs-monitor-ipsec.in:1300:5: E303 too many blank lines (2) > make[2]: *** [Makefile:6589: flake8-check] Error 1
I just checked and I didn't have flake8 installed on the machine I was working on so the test must have skipped. Thanks for catching this. I will fix. > > > Also copying Aaron on this, as his Robot did not complain ;) > > > //Eelco > > > On 8 Mar 2021, at 18:57, Mark Gray wrote: > >> This series fixes IPv6 support for Libreswan and introduces >> IPsec system tests for Libreswan. >> >> Mark Gray (4): >> system-common-macros: clean up veth device on test failure >> ipsec: Allow custom file locations >> ipsec: IPv6 default route support for Libreswan >> ipsec: Introduce IPsec system tests for Libreswan >> >> ipsec/ovs-monitor-ipsec.in | 160 +++++++++++--- >> tests/automake.mk | 3 +- >> tests/system-common-macros.at | 2 +- >> tests/system-ipsec.at | 379 >> +++++++++++++++++++++++++++++++++ >> tests/system-kmod-testsuite.at | 1 + >> 5 files changed, 519 insertions(+), 26 deletions(-) >> create mode 100644 tests/system-ipsec.at >> >> -- >> 2.27.0 >> >> >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
