On 3/28/21 6:23 AM, Han Zhou wrote: > For the series: > Acked-by: Han Zhou <[email protected] <mailto:[email protected]>> > > On Wed, Mar 24, 2021 at 2:33 AM Dumitru Ceara <[email protected] > <mailto:[email protected]>> wrote: > > Patch 1/3 of the series makes the ovsdb-idl tests more future proof > by trying to ensure more predictable output from test-ovsdb. > > Paches 2/3 and 3/3 fix problems in the IDL change tracking code. > > Changes in v4: > - Patch 1/3: > - Rebase. > - Readd UUID to test-ovsdb.py output. > - Fix indentation in test-ovsdb.c. > - Patch 2/3: > - Rename orphan_rows to deleted_untracked_rows. > - Rename ovsdb_idl_process_orphans() to ovsdb_idl_reparse_deleted(). > - Revert changes to ovsdb_idl_row_reparse_backrefs(). > - Unified test-ovsdb.c and test-ovsdb.py output for simple3's uset and > uref columns. > - Added two more tests for deletion of strong references due to monitor > condition change. > - Patch 3/3: > - Rebase. > > Changes in v3: > - Patch 1/3: > - Changed expected output of ovsdb-cluster.at <http://ovsdb-cluster.at> > to reflect the new > formatting in test-ovsdb output. > - Fixed typo in test-ovsdb.py. > - Patch 2/3: > - Rework based on the discussion with Ilya. > - Added more tests. > - Add patch 3/3: > - Mark reference sources as "udpated" when destinations are deleted. > > Changes in v2: > - Patch 1/2: > - reworked the patch to improve the output of test-ovsdb.c and > test-ovsdb.py themselves. > - Patch 2/2: > - added a test for strong references. > > Dumitru Ceara (3): > ovsdb-idl.at <http://ovsdb-idl.at>: Make test outputs more > predictable. > ovsdb-idl: Preserve references for deleted rows. > ovsdb-idl: Mark arc sources as updated when destination is deleted. > > > lib/ovsdb-idl.c | 137 +++++++-- > lib/ovsdb-idl.h | 2 > tests/ovsdb-cluster.at <http://ovsdb-cluster.at> | 2 > tests/ovsdb-idl.at <http://ovsdb-idl.at> | 747 > ++++++++++++++++++++++++++++++++---------------- > tests/test-ovsdb.c | 246 +++++++++++----- > tests/test-ovsdb.py | 119 +++++--- > 6 files changed, 861 insertions(+), 392 deletions(-) >
Thanks, Dumitru and Han! I applied this series to master and branch-2.15. It looks like we should have these fixes on LTS, but patches are not directly applicable. Dumitru, could you prepare backports? Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
