On 4/5/21 4:42 AM, Tonghao Zhang wrote: > On Mon, Apr 5, 2021 at 1:32 AM Ilya Maximets <[email protected]> wrote: >> >> 'dpif_execute_helper_cb' doesn't initilalize the 'hash' field that >> may be passed down to datapath and might cause execution of a different >> set of actions, e.g. on recirculation. >> >> Thread 6 handler27: >> Conditional jump or move depends on uninitialised value(s) >> at 0x53A2C2: dpif_netlink_encode_execute (dpif-netlink.c:1841) >> by 0x53A2C2: dpif_netlink_operate__ (dpif-netlink.c:1919) >> by 0x53A82D: dpif_netlink_operate_chunks (dpif-netlink.c:2238) >> by 0x53A82D: dpif_netlink_operate (dpif-netlink.c:2297) >> by 0x48135F: dpif_operate (dpif.c:1366) >> by 0x481923: dpif_execute.part.24 (dpif.c:1320) >> by 0x481C46: dpif_execute (dpif.c:1312) >> by 0x481C46: dpif_execute_helper_cb (dpif.c:1243) >> by 0x4AE943: odp_execute_actions (odp-execute.c:865) >> by 0x47F272: dpif_execute_with_help (dpif.c:1296) >> by 0x4812FF: dpif_operate (dpif.c:1422) >> by 0x442226: handle_upcalls (ofproto-dpif-upcall.c:1617) >> by 0x442226: recv_upcalls.isra.36 (ofproto-dpif-upcall.c:855) >> by 0x442351: udpif_upcall_handler (ofproto-dpif-upcall.c:755) >> by 0x4FDE2C: ovsthread_wrapper (ovs-thread.c:383) >> by 0x5E19159: start_thread (in /usr/lib64/libpthread-2.28.so) >> by 0x69ECF72: clone (in /usr/lib64/libc-2.28.so) >> Uninitialised value was created by a stack allocation >> at 0x481966: dpif_execute_helper_cb (dpif.c:1159) >> >> Additionally added a missing comment to the 'struct dpif_execute'. > Thanks Ilya > > Acked-by: Tonghao Zhang <[email protected]>
Thanks! Applied to master and backported down to 2.13. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
