On 19/04/2021 20:48, Hariprasad Govindharajan wrote:
> Modify ci linux build script to use the latest DPDK stable release.
> Modify Documentation to use the latest DPDK stable release 19.11.8
> Update NEWS file to reflect the latest DPDK stable release.
> 

The mechanics of the patch look ok, and I can build OVS with make/meson
DPDK 19.11.8.

Given that this DPDK release was especially for OVS and the issue seems
to have a very long history, I think it needs an Acked-by: from
Christian and Sunil and some further explanation and pointers to the
discussion in the commit message. (Same comment for 2.14 branch version)

> Signed-off-by: Hariprasad Govindharajan <[email protected]>
> ---
>  .ci/linux-build.sh                       | 2 +-
>  Documentation/faq/releases.rst           | 2 +-
>  Documentation/intro/install/dpdk.rst     | 8 ++++----
>  Documentation/topics/dpdk/vhost-user.rst | 6 +++---
>  NEWS                                     | 2 +-
>  5 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index c1cf85d..b22ad95 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -182,7 +182,7 @@ fi
>  
>  if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then
>      if [ -z "$DPDK_VER" ]; then
> -        DPDK_VER="19.11.6"
> +        DPDK_VER="19.11.8"
>      fi
>      install_dpdk $DPDK_VER
>      # Enable pdump support in OVS.
> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
> index 4a0dcac..70a0e9b 100644
> --- a/Documentation/faq/releases.rst
> +++ b/Documentation/faq/releases.rst
> @@ -192,7 +192,7 @@ Q: What DPDK version does each Open vSwitch release work 
> with?
>      2.10.x       17.11.10
>      2.11.x       18.11.11
>      2.12.x       18.11.11
> -    2.13.x       19.11.6
> +    2.13.x       19.11.8
>      ============ ========
>  
>  Q: Are all the DPDK releases that OVS versions work with maintained?
> diff --git a/Documentation/intro/install/dpdk.rst 
> b/Documentation/intro/install/dpdk.rst
> index 050e554..b603b6f 100644
> --- a/Documentation/intro/install/dpdk.rst
> +++ b/Documentation/intro/install/dpdk.rst
> @@ -42,7 +42,7 @@ Build requirements
>  In addition to the requirements described in :doc:`general`, building Open
>  vSwitch with DPDK will require the following:
>  
> -- DPDK 19.11.6
> +- DPDK 19.11.8
>  
>  - A `DPDK supported NIC`_
>  
> @@ -71,9 +71,9 @@ Install DPDK
>  #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
>  
>         $ cd /usr/src/
> -       $ wget https://fast.dpdk.org/rel/dpdk-19.11.6.tar.xz
> -       $ tar xf dpdk-19.11.6.tar.xz
> -       $ export DPDK_DIR=/usr/src/dpdk-stable-19.11.6
> +       $ wget https://fast.dpdk.org/rel/dpdk-19.11.8.tar.xz
> +       $ tar xf dpdk-19.11.8.tar.xz
> +       $ export DPDK_DIR=/usr/src/dpdk-stable-19.11.8
>         $ cd $DPDK_DIR
>  
>  #. (Optional) Configure DPDK as a shared library
> diff --git a/Documentation/topics/dpdk/vhost-user.rst 
> b/Documentation/topics/dpdk/vhost-user.rst
> index d020115..b10daa5 100644
> --- a/Documentation/topics/dpdk/vhost-user.rst
> +++ b/Documentation/topics/dpdk/vhost-user.rst
> @@ -392,9 +392,9 @@ To begin, instantiate a guest as described in 
> :ref:`dpdk-vhost-user` or
>  DPDK sources to VM and build DPDK::
>  
>      $ cd /root/dpdk/
> -    $ wget https://fast.dpdk.org/rel/dpdk-19.11.6.tar.xz
> -    $ tar xf dpdk-19.11.6.tar.xz
> -    $ export DPDK_DIR=/root/dpdk/dpdk-stable-19.11.6
> +    $ wget https://fast.dpdk.org/rel/dpdk-19.11.8.tar.xz
> +    $ tar xf dpdk-19.11.8.tar.xz
> +    $ export DPDK_DIR=/root/dpdk/dpdk-stable-19.11.8
>      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>      $ cd $DPDK_DIR
> diff --git a/NEWS b/NEWS
> index 32ec919..733c785 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,7 +1,7 @@
>  v2.13.4 - xx xxx xxxx
>  ---------------------
>     - DPDK:
> -     * OVS validated with DPDK 19.11.6. It is recommended to use this version
> +     * OVS validated with DPDK 19.11.8. It is recommended to use this version
>         until further releases.
>     - ovs-ctl:
>       * New option '--no-record-hostname' to disable hostname configuration
> 

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to