Re: [ovs-dev] [PATCH v2 25/28] dpif-netdev: Make megaflow and mark mappings thread objects

[Maxime Coquelin]

On 4/12/21 5:20 PM, Gaetan Rivet wrote:
> In later commits hardware offloads are managed in several threads.
> Each offload is managed by a thread determined by its flow's 'mega_ufid'.
> 
> As megaflow to mark and mark to flow mappings are 1:1 and 1:N
> respectively, then a single mark exists for a single 'mega_ufid', and
> multiple flows uses the same 'mega_ufid'. Because the managing thread will
> be choosen using the 'mega_ufid', then each mapping does not need to be

s/choosen/chosen/

> shared with other offload threads.
> 
> The mappings are kept as cmap as upcalls will sometimes query them before
> enqueuing orders to the offload threads.
> 
> To prepare this change, move the mappings within the offload thread
> structure.
> 
> Signed-off-by: Gaetan Rivet <gr...@u256.net>
> Reviewed-by: Eli Britstein <el...@nvidia.com>
> ---
>  lib/dpif-netdev.c | 41 +++++++++++++++++++----------------------
>  1 file changed, 19 insertions(+), 22 deletions(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>

Thanks,
Maxime

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev