On 4/29/21 3:55 AM, Han Zhou wrote: > This reverts commit 0ba2e1a2e2c413f057ac198e4c2bcf00ac40b19f.
Oops, I should've thought about this when reviewing the initial patch, good that the CI caught it. > > System tests with "dp-groups=yes" are all failing due to the warning > log. Need to investigate why the warning appears. But before that is > clear, revert this log level change to make CI pass. I would remove this part of the commit log or change it to something like: "With conditional monitoring, if a logical flow refers to a datapath group that doesn't contain any local datapaths, ovsdb-server will send updates with lflow.logical_dp_group set to NULL. This is a valid case and we shouldn't log a warning message for it." It's actually expected to have lflows with both logical_dp_group and logical_datapath NULL now since we unconditionally monitor lflows with datapath group set. With conditional monitoring it might be that there are lflows that refer to a DPG but none of the DPG datapaths are local to ovn-controller so they won't be monitored. In that case lflow.logical_dp_group will be NULL. It's not a bug however so the old VLOG_DBG was fine. For the revert patch: Acked-by: Dumitru Ceara <[email protected]> Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
