Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around operator
#874 FILE: lib/netlink-devlink.c:139:
(bool (*)(struct ofpbuf*, void*))&nl_dl_parse_port_policy,
ERROR: Inappropriate spacing in pointer declaration
ERROR: Inappropriate spacing around cast
WARNING: Line lacks whitespace around operator
#875 FILE: lib/netlink-devlink.c:140:
(void*)port_entry);
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around operator
#884 FILE: lib/netlink-devlink.c:149:
(bool (*)(struct ofpbuf*, void*))&nl_dl_parse_info_policy,
ERROR: Inappropriate spacing in pointer declaration
ERROR: Inappropriate spacing around cast
WARNING: Line lacks whitespace around operator
#885 FILE: lib/netlink-devlink.c:150:
(void*)info_entry);
ERROR: Improper whitespace around control block
#901 FILE: lib/netlink-devlink.c:166:
switch(policy[attr_idx].type) {
ERROR: Inappropriate bracing around statement
#1068 FILE: lib/netlink-devlink.c:333:
else
WARNING: Line lacks whitespace around operator
#1206 FILE: lib/netlink-devlink.c:471:
||!attr_fill_version(DEVLINK_ATTR_INFO_VERSION_RUNNING, attrs,
WARNING: Line lacks whitespace around operator
#1208 FILE: lib/netlink-devlink.c:473:
||!attr_fill_version(DEVLINK_ATTR_INFO_VERSION_STORED, attrs,
WARNING: Line is 95 characters long (recommended limit is 79)
#1710 FILE: utilities/devlink.c:81:
VLOG_INFO("function eth_addr: "ETH_ADDR_FMT,
ETH_ADDR_ARGS(port_entry->function.eth_addr));
ERROR: Improper whitespace around control block
#1826 FILE: utilities/devlink.c:197:
if(!nl_dl_parse_port_policy(&buf, &port_entry)) {
WARNING: Line is 80 characters long (recommended limit is 79)
#1831 FILE: utilities/devlink.c:202:
genl->cmd == DEVLINK_CMD_PORT_GET ? "DEVLINK_CMD_PORT_GET" :
WARNING: Line is 80 characters long (recommended limit is 79)
#1832 FILE: utilities/devlink.c:203:
genl->cmd == DEVLINK_CMD_PORT_SET ? "DEVLINK_CMD_PORT_SET" :
WARNING: Line is 80 characters long (recommended limit is 79)
#1833 FILE: utilities/devlink.c:204:
genl->cmd == DEVLINK_CMD_PORT_NEW ? "DEVLINK_CMD_PORT_NEW" :
WARNING: Line is 80 characters long (recommended limit is 79)
#1834 FILE: utilities/devlink.c:205:
genl->cmd == DEVLINK_CMD_PORT_DEL ? "DEVLINK_CMD_PORT_DEL" :
Lines checked: 1877, Warnings: 11, Errors: 9
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
