This comment-only patch could use a review.
On Wed, Apr 14, 2021 at 07:45:04PM -0700, Ben Pfaff wrote:
> Commit a14502a7c529 ("classifier: Retire partitions.") in 2015 removed
> OVS support for tags for the second time (!), so these comments about
> them should be removed too.
>
> Signed-off-by: Ben Pfaff <[email protected]>
> ---
> lib/mac-learning.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/lib/mac-learning.c b/lib/mac-learning.c
> index 9442858d95c3..3d5293d3b34c 100644
> --- a/lib/mac-learning.c
> +++ b/lib/mac-learning.c
> @@ -491,12 +491,8 @@ mac_learning_lookup(const struct mac_learning *ml,
> const struct eth_addr dst, uint16_t vlan)
> {
> if (eth_addr_is_multicast(dst)) {
> - /* No tag because the treatment of multicast destinations never
> - * changes. */
> return NULL;
> } else if (!is_learning_vlan(ml, vlan)) {
> - /* We don't tag this property. The set of learning VLANs changes so
> - * rarely that we revalidate every flow when it changes. */
> return NULL;
> } else {
> struct mac_entry *e = mac_entry_lookup(ml, dst, vlan);
> --
> 2.29.2
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev