Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 93 characters long (recommended limit is 79)
#677 FILE: utilities/ovn-sbctl.8.xml:7:
<p><code>ovn-sbctl</code> [<var>options</var>] <var>command</var>
[<var>arg</var>...]</p>
WARNING: Line is 82 characters long (recommended limit is 79)
#909 FILE: utilities/ovn-sbctl.8.xml:239:
<xi:include href="lib/daemon.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 80 characters long (recommended limit is 79)
#912 FILE: utilities/ovn-sbctl.8.xml:242:
<xi:include href="lib/vlog.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 81 characters long (recommended limit is 79)
#917 FILE: utilities/ovn-sbctl.8.xml:247:
<xi:include href="lib/table.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 89 characters long (recommended limit is 79)
#925 FILE: utilities/ovn-sbctl.8.xml:255:
<xi:include href="lib/ssl-bootstrap.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 82 characters long (recommended limit is 79)
#929 FILE: utilities/ovn-sbctl.8.xml:259:
<xi:include href="lib/common.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Line is 127 characters long (recommended limit is 79)
#965 FILE: utilities/ovn-sbctl.8.xml:295:
<dt>[<code>--may-exist</code>] <code>chassis-add <var>chassis</var>
<var>encap-type</var> <var>encap-ip</var></code></dt>
WARNING: Line is 83 characters long (recommended limit is 79)
#982 FILE: utilities/ovn-sbctl.8.xml:312:
<dt>[<code>--if-exists</code>] <var>chassis-del
<var>chassis</var></var></dt>
WARNING: Line is 106 characters long (recommended limit is 79)
#1004 FILE: utilities/ovn-sbctl.8.xml:334:
<dt>[<code>--may-exist</code>] <code>lsp-bind <var>logical-port</var>
<var>chassis</var></code></dt>
WARNING: Line is 89 characters long (recommended limit is 79)
#1019 FILE: utilities/ovn-sbctl.8.xml:349:
<dt>[<code>--if-exists</code>] <code>lsp-unbind
<var>logical-port</var></code></dt>
WARNING: Line is 213 characters long (recommended limit is 79)
#1036 FILE: utilities/ovn-sbctl.8.xml:366:
<dt>[<code>--uuid</code>]
[<code>--ovs</code>[<code>=<var>remote</var>]</code>] [<code>--stats</code>]
[<code>--vflows</code>] <code>lflow-list</code> [<var>logical-datapath</var>]
[<var>lflow</var>...]</dt>
WARNING: Line is 90 characters long (recommended limit is 79)
#1091 FILE: utilities/ovn-sbctl.8.xml:421:
<dt>[<code>--uuid</code>] <code>dump-flows</code>
[<var>logical-datapath</var>]</dt>
WARNING: Line is 114 characters long (recommended limit is 79)
#1116 FILE: utilities/ovn-sbctl.8.xml:446:
<dt>[<code>--inactivity-probe=</code><var>msecs</var>]
<code>set-connection</code> <var>target</var>...</dt>
WARNING: Line is 87 characters long (recommended limit is 79)
#1212 FILE: utilities/ovn-sbctl.8.xml:542:
<xi:include href="lib/db-ctl-base.xml"
xmlns:xi="http://www.w3.org/2003/XInclude"/>
WARNING: Comment with 'xxx' marker
#1547 FILE: utilities/ovn-sbctl.c:121:
/* XXX add verification that table is empty */
WARNING: Line is 80 characters long (recommended limit is 79)
#1751 FILE: utilities/ovn-sbctl.c:465:
ctl_error(ctx, "lport (%s) has already been binded to chassis (%s)",
Lines checked: 2104, Warnings: 16, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev