Ok. Thanks Ben. Will take care of this. -Vasu
*Vasu Dasari* On Mon, May 10, 2021 at 7:57 PM Ben Pfaff <[email protected]> wrote: > On Mon, May 10, 2021 at 07:38:08PM -0400, Vasu Dasari wrote: > > 1. Adding Nicira extensions for Flow Monitoring was pretty > straightforward > > with the existing code base. As you might have seen, I just had to tweak > > some functions to get this to work. I do not have any hard opinions > against > > your point that we should not duplicate functionality with Nicira > > extensions and OpenFlow 1.4,1.5. But my only suggestion is to make the > > support for OF 1.4, 1.5 flow monitoring messages to be implemented as a > > separate commit, as I think it is going to add new functions to make that > > happen. > > I agree. For this commit, though, I think that it should only add > support up to 1.3, that is, ofp-msgs.h should say 1.0-1.3, not 1.0+. > > Thanks, > > Ben. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
