On 5/10/21 3:16 PM, Dumitru Ceara wrote: > On 5/6/21 2:47 PM, Ilya Maximets wrote: > > [...] > > Oops, I meant to send this along with the acked-by: > >> >> diff --git a/ovsdb/raft.c b/ovsdb/raft.c >> index d2ff643b2..658a016b2 100644 >> --- a/ovsdb/raft.c >> +++ b/ovsdb/raft.c >> @@ -4160,9 +4160,24 @@ raft_may_snapshot(const struct raft *raft) >> && !raft->leaving >> && !raft->left >> && !raft->failed >> + && raft->role != RAFT_LEADER >> && raft->last_applied >= raft->log_start); >> } >> >> +/* Prepares for soon snapshotting. */ > > Nit: one space too many. And I'd probably rephrase this to "Prepare for > snapshotting soon.", but I'm not a native speaker, I'm not sure if > that's better. >
Thanks! I'm not sure if this variant is better and I wanted to keep comments uniform with other functions. So, I removed the extra space, but kept the text as is. Applied to master and backported down to 2.13 as this change is important for large scale setups. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
