On 5/12/21 2:29 PM, Numan Siddique wrote: > On Wed, May 12, 2021 at 8:14 AM Numan Siddique <[email protected]> wrote: >> >> On Fri, May 7, 2021 at 12:23 PM Ilya Maximets <[email protected]> wrote: >>> >>> This flow already matches on 'arp.tpa == ip_address', so instead of >>> setting 'arp.spa' to this 'ip_address' we can just swap values of >>> 'arp.tpa' and 'arp.spa'. >>> >>> This elimintes the variable from the 'action', allowing us to just >>> use the list of all IPs in the match. >>> >>> Current OVN generates one ARP flow for each load balancer IP for >>> each router port. So, if we have 100 ports and 1000 IP addresses, >>> northd will generate 10^5 ARP flows. With this change it will >>> generate only 100 of them. >>> >>> In case of ovn-k8s scale test, this change alone reduced the database >>> size from 500 to 200 MB. >>> >>> Also added more test cses for loadbalancer flows. >>> >>> Signed-off-by: Ilya Maximets <[email protected]> >> >> Thanks Ilya for the improvements. >> >> I applied this patch to the main branch with the below changes to >> ovn-northd.8.xml >> >> -------- >> diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml >> index b63b69b5d0..bbc28d7ab3 100644 >> --- a/northd/ovn-northd.8.xml >> +++ b/northd/ovn-northd.8.xml >> @@ -2352,8 +2352,7 @@ eth.src = xreg0[0..47]; >> arp.op = 2; /* ARP reply. */ >> arp.tha = arp.sha; >> arp.sha = xreg0[0..47]; >> -arp.tpa = arp.spa; >> -arp.spa = <var>A</var>; >> +arp.tpa <-> arp.spa; > > Oops. Sorry Ilya for goofing up here. > It should have been > arp.tpa <-> arp.spa; > > I fixed this in a separate commit. >
No problem. Thanks for spotting the missing documentation part! It would be great if we can backport it down to 20.12 as this is essential change for large scale deployments. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
