On Thu, 2021-05-13 at 10:12 -0700, Ben Pfaff wrote: > On Wed, May 12, 2021 at 08:40:43PM -0500, Dan Williams wrote: > > On Tue, 2021-04-13 at 20:50 -0500, Dan Williams wrote: > > > After creating the new cluster database write a raft entry that > > > sets the desired election timer. This allows CMSes to set the > > > election timer at cluster start and avoid an error-prone > > > election timer modification process after the cluster is up. > > > > > > Reported-at: https://bugzilla.redhat.com/1831778 > > > > Anyone have thoughts on this or a better approach? > > > > Thanks, > > Dan > > From a UI point of view, I'd argue for a command-line option rather > than > an extra argument, because if we need one of these kinds of optional > tweaks we'll probably need more at some point, and half a dozen > optional > arguments are unmanageable without names.
Should the command error out if the timer is set on a DB that's already part of a cluster? That was a bit confusing to me, I wasn't sure when it was valid to set the timer into an on-disk DB... > From a docs point of view, this needs documentation in the --help > text, > in the manpage, and probably a NEWS item too. I'd recommend that the > documentation explain what the election timer is, what the default > is, > what range of values admins should consider, and how they can make a > reasonable choice. (That could be just a sentence or two.) Good point, will do. Dan _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
