On 26 May 2021, at 14:46, Matteo Croce wrote:
> On Wed, May 26, 2021 at 2:34 PM Eelco Chaudron <[email protected]> wrote: >> On 18 May 2021, at 20:15, Ilya Maximets wrote: >>>> +/* Tests whether 'dpif' datapath supports decrement of the IP TTL via >>>> + * OVS_ACTION_DEC_TTL. */ >>>> +static bool >>>> +check_dec_ttl_action(struct dpif *dpif) >>>> +{ >>>> + struct odputil_keybuf keybuf; >>>> + struct flow flow = { 0 }; >>> >>> It's probbaly better to just memset it as in other similar functions >>> to avoid compiler's complains. >> >> ACK, will use a memset here. >> > > Which complaint? Memset is a bit slower because it clears also the > struct padding. See the robot’s responses to this patchset: ofproto/ofproto-dpif.c:1195:12: error: missing braces around initializer [-Werror=missing-braces] struct flow flow = { 0 }; But I guess memset is ok, as other similar functions use it. > > -- > per aspera ad upstream _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
