Hi, I’ve posted a new version of this patch: https://patchwork.ozlabs.org/project/ovn/list/?series=248346
Regards, Vladislav Odintsov > On 11 Jun 2021, at 01:45, Ben Pfaff <[email protected]> wrote: > > On Fri, Jun 11, 2021 at 12:13:46AM +0200, Dumitru Ceara wrote: >> On 6/10/21 11:47 PM, Ben Pfaff wrote: >>> On Fri, Jun 11, 2021 at 12:28:47AM +0300, Vladislav Odintsov wrote: >>>> After patch would be accepted I’d like to send backport bugfix patch down >>>> to >>>> supported branches. Is it better to use old-style AT_CHECK in tests to >>>> cleanly >>>> apply this patch to branches without `check` support? Or in master branch I >>>> should only use new-style and then rewrite it while backporting? >>> >>> One reasonable option for backporting is to add the definition of >>> check(). It's a really simple shell function: >>> >>> check() { >>> echo "$@" >>> AT_CHECK(["$@"]) >>> } >>> >>> If you're only changing a few tests and you didn't want to update >>> ovn-macros.at (I see that the commit that added check() is pretty big), >>> then you could just add that definition to each one. >>> >> >> Luckily Numan already backported commit 4afe409e95c7 ("tests: Introduce >> new testing helpers.") to all stable branches so check() is available on >> all branches >= 20.03. >> > > Even better. > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
