On Tue, Jun 15, 2021 at 9:28 AM Mark Michelson <[email protected]> wrote: > > On 6/15/21 9:24 AM, Mark Michelson wrote: > > Signed-off-by: Mark Michelson <[email protected]>
For both the patches in the series: Acked-by: Numan Siddique <[email protected]> > > --- > > controller/ofctrl.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/controller/ofctrl.c b/controller/ofctrl.c > > index 053631590..48d001506 100644 > > --- a/controller/ofctrl.c > > +++ b/controller/ofctrl.c > > @@ -1259,7 +1259,6 @@ ofctrl_flood_remove_flows(struct > > ovn_desired_flow_table *flow_table, > > * Copying the sb_uuids into an array. */ > > struct uuid *sb_uuids; > > sb_uuids = xmalloc(hmap_count(flood_remove_nodes) * sizeof *sb_uuids); > > - struct hmap flood_remove_uuids = HMAP_INITIALIZER(&flood_remove_uuids); > > HMAP_FOR_EACH (ofrn, hmap_node, flood_remove_nodes) { > > sb_uuids[n++] = ofrn->sb_uuid; > > } > > > > This series is probably the most trivial I've ever put up for review. I > almost merged this series directly without first doing a review. > However, I talked myself into going through the review process. I'm > curious how people would feel if devs committed changes like this > directly instead of engaging in the review process. I don't have a strong opinion. I'm fine for such trivial patches. Thanks Numan > > Thanks, > Mark > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
