On Fri, 2021-06-18 at 21:49 +0200, Dumitru Ceara wrote: > On 6/4/21 10:00 PM, Dan Williams wrote: > > Inspried by: > > > > 3b6362d64e86b northd: Avoid memory reallocation while building lb > > rules. > > > > Signed-off-by: Dan Williams <[email protected]> > > --- > > NOTE: this is driven by visual inspection not perf data. But it > > shouldn't be worse than current code and should be better for > > large numbers of ACLs I think. > > The changes look OK to me. > > Acked-by: Dumitru Ceara <[email protected]> > > However, I wonder how many such optimizations we can implement > without > affecting maintainability. Mark suggested an approach [0].
I'm happy to drop my patch in favor of Mark's. I think mine is a subset of his. Dan > > CC-ing Ilya too, maybe he has some more suggestions, maybe there's a > way > to better use the OVS dynamic strings. > > Regards, > Dumitru > > [0] > https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/384043.html > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
