On 6/25/21 4:36 PM, Numan Siddique wrote: > On Fri, Jun 25, 2021 at 7:51 AM Dumitru Ceara <[email protected]> wrote: >> >> It's valid that port_groups contain non-vif ports, they can actually >> contain any type of logical_switch_port. >> >> Also, there's no need to allocate a new sset containing the local ports' >> names every time the I-P engine processes a change, we can maintain a >> sset and incrementally update it when port bindings are added/removed. >> >> Reported-at: https://github.com/ovn-org/ovn/pull/61#issuecomment-865094163 >> Reported-by: Antonio Ojea <[email protected]> >> Fixes: 0cfeba6b55e3 ("ovn-controller: Fix port group conjunction flow >> explosion problem.") >> Signed-off-by: Dumitru Ceara <[email protected]> > > Hi Dumitru,
Hi Numan, Thanks for the review! > > Thanks for the fix. I think it would be great to have a test case to > exercise the scenario. Definitely, I'll add one in v2. > > I've one small nit comment. Otherwise the patch looks good to me. I'll take care of the comment too in v2. > > Thanks > Numan > Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
