Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

[Eelco Chaudron]

On 29 Jun 2021, at 13:59, Amber, Kumar wrote:

> Hi Eelco,
>
> Thanks a lot for the comments and my replies are inline.
>

<SNIP>

>>> +        return;
>>> +    }
>>> +
>>> +    /* Add all mfex functions to reply string. */
>>> +    struct ds reply = DS_EMPTY_INITIALIZER;
>>> +    ds_put_cstr(&reply, "Available Optimized Miniflow Extracts:\n");
>>> +    for (uint32_t i = 0; i < count; i++) {
>>> +        ds_put_format(&reply, "  %s (available: %s)\n",
>>> +                      mfex_impls[i].name, mfex_impls[i].available ?
>>> +                      "True" : "False");
>>> +    }
>>> +    unixctl_command_reply(conn, ds_cstr(&reply));
>>> +    ds_destroy(&reply);
>>
>> I think this command must output the currently configured values for all
>> data paths, or else there is no easy way to see the current setting.
>>
>
> We are planning to do a separate patch for implementing the same for DPIF,
> MFEX adnd DPCLS.
>

If you do, please do it ASAP, as I think this feature should not get in without 
being able to see in the field what the actual configuration is.

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev