On 6/24/21 11:18 AM, Van Haaren, Harry wrote: >> -----Original Message----- >> From: Timothy Redaelli <[email protected]> >> Sent: Wednesday, June 23, 2021 11:10 PM >> To: [email protected] >> Cc: Van Haaren, Harry <[email protected]> >> Subject: [PATCH v2] dpif-netdev: apply subtable-lookup-prio-set on any >> datapath >> >> Currently, if you try to set subtable-lookup-prio-set when you don't have >> any datapath (for example if an user wants to set AVX512 before creating >> any bridge) it sets it globally (dpcls_subtable_set_prio), >> but it returns an error: >> >> please specify an existing datapath >> ovs-appctl: ovs-vswitchd: server returned an error >> >> and, in this case, the exit code of ovs-appctl is 2. > > Good catch. Just to call out that the command was actually having effect, > just that because there was no datapath to update, it was later "failing" to > find a datapath hence error return. > > >> This commit changes the behaviour by removing the [datapath] optional >> parameter of subtable-lookup-prio-set and by changing the priority >> level on any datapath and globally. This means if you don't have any >> datapath or if you have only one datapath, the behaviour is the same as >> now, but without the confusing error when you don't have any datapath. >> >> Fixes: 3d018c3ea79d ("dpif-netdev: add subtable lookup prio set command.") >> Cc: [email protected] >> Signed-off-by: Timothy Redaelli <[email protected]> > > I like the code simplification, and command UX simplification too, thanks! > > Acked-by: Harry van Haaren <[email protected]>
Thanks! Applied. Backported down to 2.14. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
