On 7/2/21 4:26 PM, [email protected] wrote: > From: Anton Ivanov <[email protected]> > > can_parallelise_hashes() was explicitly using the local OVN specific > copy with the ovn_ prefix instead of the define. > > This prevents any work on migrating the parallelisation to the ovs > tree. > > Signed-off-by: Anton Ivanov <[email protected]> > --- > northd/ovn-northd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index 83746f4ab..bc01a05ca 100644 > --- a/northd/ovn-northd.c > +++ b/northd/ovn-northd.c > @@ -13332,7 +13332,7 @@ ovnnb_db_run(struct northd_context *ctx, > > use_parallel_build = > (smap_get_bool(&nb->options, "use_parallel_build", false) && > - ovn_can_parallelize_hashes(false)); > + can_parallelize_hashes(false)); > > use_logical_dp_groups = smap_get_bool(&nb->options, > "use_logical_dp_groups", false); >
This looked good to me: Acked-by: Dumitru Ceara <[email protected]> However, checking if there are other cases like this I noticed: #define ovn_run_pool(pool) ovn_run_pool(pool) Which confused me.. Should that be "#define run_pool(pool) ..." or should it go? If we can remove it the we should also remove the whole ovn_run_pool() function. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
