On Wed, Jun 30, 2021 at 05:43:53PM +0200, Adrian Moreno wrote: > As discussed in [1], "igmp" is not a special OF header so > ofp_parse_protocol() does not accept it. However, it's still being > printed by match_format(). > > This makes flow dump restoration fail if it contains this match, > which affects for instance the ovs-save script used by "ovs-ctl restart" > to make ovs-vswitchd restart have less impact on the datapath. > > I am aware this change might break users that already expect this > keyword but on the other hand, the fact that flows cannot be saved and > restored could be considered a bug. > > An alternative to make "ovs-save" work would be to use "sed" to rewrite > the match, but that would still expose the failure to any user not using > that script. > > Sending the patch to gather feedback on this topic > > [1] > https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/
Ilya, I think your opinion is the most important here. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
