On Fri, Jul 09, 2021 at 11:11:48AM +0200, Lorenzo Bianconi wrote:
> On Jul 08, Ben Pfaff wrote:
> > On Thu, Jul 08, 2021 at 06:40:01PM +0200, Lorenzo Bianconi wrote:
> > > This series respin CoPP support introduced here [0] by Dumitru rebasing 
> > > on top
> > > of ovn master branch and adding some missing meters (e.g. bfd or acl 
> > > reject).
> > > The main goal of this series is to continue the discussion about the 
> > > proposed
> > > approach and to align on CMS APIs.
> > > For the moment DDLog is not supported yet and it will be added in a 
> > > subsequent
> > > series.
> > 
> > I wrote a ddlog implementation on top of v7 and pushed it here:
> > https://github.com/blp/ovs-reviews/commits/COPP-v7%2Bddlog
> > 
> > There are just two patches on top of yours.  I'd prefer if the first one
> > "ovn-northd-ddlog: Optimize AggregatedFlow rules." be inserted somewhere
> > in your series and if the second one "Implement CoPP for DDlog." were
> > squashed in the right place in your series.
> 
> Hi Ben,
> 
> thx a lot for the series.
> Compiling the code I have this error:
> 
> error: module 'copp' imported by northd/ovn_northd.dl not found. Paths 
> searched:
> /home/lorenzo/workspace/ovn/northd/copp.dl
> /home/lorenzo/workspace/ddlog-v0.38/lib/copp.dl
> 
> I think you have not committed copp.dl, correct?

Oops.  I am sorry about that.  It was careless.  I have pushed an
additional patch that should add it properly.  It would be best to fold
that in as well.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to