On 7/13/21 6:12 PM, Dumitru Ceara wrote:
>>>> + relay_remotes++; /* Skip the ':'. */
>>>> }
>>>> -
>>>> db = xzalloc(sizeof *db);
>>>> - db->filename = xstrdup(filename);
>>>> + db->filename = name;
>>>>
>>>> struct ovsdb_schema *schema;
>>>> - if (ovsdb_storage_is_clustered(storage)) {
>>>> + if (is_relay || ovsdb_storage_is_clustered(storage)) {
>>>> schema = NULL;
>>>> } else {
>>>> struct json *txn_json;
>>>
>>> Not introduced by this patch but I noticed that in this "else" we might
>>> return and leak 'db' and 'db->filename'.
>>
>> Yes, looks so. But this should be fixed by a separate patch and backported.
>>
>
> Will you be sending a patch or shall I?
I can do that, but I don't have enough time for it right now.
So, if you have a couple of free cycles, go ahead.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
