Hi Eelco, > -----Original Message----- > From: Eelco Chaudron <[email protected]> > Sent: Wednesday, July 14, 2021 4:21 PM > To: Amber, Kumar <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; Van > Haaren, Harry <[email protected]>; Ferriter, Cian > <[email protected]>; Stokes, Ian <[email protected]> > Subject: Re: [v11 06/11] dpif-netdev: Add packet count and core id paramters > for study > > > > On 14 Jul 2021, at 12:30, Eelco Chaudron wrote: > > > On 14 Jul 2021, at 4:02, kumar Amber wrote: > > > >> From: Kumar Amber <[email protected]> > >> > >> This commit introduces additional command line paramter for mfex > >> study function. If user provides additional packet out it is used in > >> study to compare minimum packets which must be processed else a > >> default value is choosen. > >> Also introduces a third paramter for choosing a particular pmd core. > >> > >> $ ovs-appctl dpif-netdev/miniflow-parser-set study 500 3 > >> > >> Signed-off-by: Kumar Amber <[email protected]> > > One additional comment, please add some (negative) test cases for the > command line options, so we know your changes work. Rather than me having > to do this manually every revision. >
Yes we did think about that but we cannot as whenever a command fails the ovs flags it as error in server that auto-mantically fails the test. Ex: > 2021-07-14T11:16:30.194Z|00082|unixctl|DBG|received request > dpif-netdev/miniflow-parser-set["-pmd","0","scalar"], id=0 > 2021-07-14T11:16:30.194Z|00083|dpif_netdev|ERR|Error: Miniflow parser not > changed, PMD thread 0 not in use, pass a valid pmd thread ID. > 2021-07-14T11:16:30.194Z|00084|unixctl|DBG|replying with error, id=0: "Error: > Miniflow parser not changed, PMD thread 0 not in use, pass a valid pmd thread > ID. > " 8. system-dpdk.at:291: 8. OVS-DPDK - MFEX Commands (system-dpdk.at:291): FAILED (system-dpdk.at:308) And Hence we cannot add the command test-case. <Snip> Br Amber _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
