On 15 Jul 2021, at 12:03, Van Haaren, Harry wrote:
>> -----Original Message----- >> From: Eelco Chaudron <[email protected]> >> Sent: Thursday, July 15, 2021 10:47 AM >> To: Van Haaren, Harry <[email protected]> >> Cc: Amber, Kumar <[email protected]>; [email protected]; >> [email protected]; [email protected]; Ferriter, Cian >> <[email protected]>; >> Stokes, Ian <[email protected]> >> Subject: Re: [v12 06/11] dpif-netdev: Add packet count and core id paramters >> for >> study > > <snip previous discussion> > >> Reading my explanation again, it’s not clear :) >> >> The command line has the following syntax: >> >> dpif-netdev/miniflow-parser-set [-pmd core] miniflow_implementation_name >> [study_pkt_cnt] >> >> The goal of the while(argc < 1) loop was to process one argument at the time. >> >> >> But your current code does the following: >> >> while(argc < 1) { >> >> if pmd: >> process pmd: >> else name >> process name: >> if study_count >> process study_count >> else >> Error >> } >> >> As you can see, the process study_count is at the wrong level. >> My suggestion was to move it to the same level. Something like this: >> >> while(argc < 1) { >> >> if !strcmp(argv[1], "-pmd") && pmd_thread_to_change != >> NON_PMD_CORE_ID: >> process pmd >> else !mfex_name >> process name >> else if (mfex_name && !study_count): >> process study_count >> else >> Error >> } > > Aha, yes OK I see what you're suggesting clearly now. > > Personally I liked the "only process extra args if study" trick (by > "indenting" it a level), > but I'll rework to your suggestion here for simplicity/consistency. Thanks looking forward to v13, a nice number to sign off on ;) _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
