On 15/07/2021 21:46, Aaron Conole wrote:
> This could probably be written something like:
> 
>        }
> 
>        if (error) {
>            return error;
>        } else if (create) {
>            VLOG_INFO("Datapath dispatch mode: %s",
>                      (dp_request.user_features & OVS_DP_F_VPORT_PIDS) ?
>                          "per-vport" : "per-cpu");
>        }
> 
> And then we trim the code a bit.  It doesn't really eliminate any
> branches (well, in truth it might add one), but it's a bit easier to
> read for me - but not a big deal.

I updated and did something like this^. I think it is in the spirit of
what you were asking for.

https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/

Thanks for the review.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to