On Wed, Jul 21, 2021 at 10:37:18AM +0200, Eelco Chaudron wrote: > > > On 20 Jul 2021, at 20:41, Ben Pfaff wrote: > > > The OVS review process has greatly slowed over the last few years. This > > is partly because I haven't been able to spend as much time on review, > > since I was once the most productive reviewer. Ilya has been able to > > step up the amount of review he does, but that still isn't enough to > > keep up with the workload. > > > > We need to come up with some way to improve things. Here are a few > > ideas, mostly from a call earlier today (that was mainly about the OVS > > conference). I hope they will prompt a discussion. > > > > * Since patches are coming in, we have people who are knowledgable about > > the code. Those people should be pitching in with reviews as well. > > It doesn't seem like they or their managers have the right incentives > > to do that. Maybe there is some way to improve the incentives. > > I do agree that it takes (very) long sometimes to get a patch > reviewed/accepted, and I do see people complain about it. However, > some of the people who do complain have not done a single > review. Maybe we can ask people who send in a patch, to review at > least one patch while they are waiting for theirs to be reviewed?
Hey, that's a great idea. Maybe I will start looking for review requests from people who do not do many reviews and suggest that they should look at other patches out for reviews. There may be some difficulty, though, that people new to OVS are less qualified to review other patches. However, trying to review is also a good way to learn. > Maybe have the zero-day robot sent them a thank you email for the > patch with a list of patches that did not yet receive a single review > comment? That's a great idea! I don't know whether it's practical, but I like the idea. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
