Salvatore Daniele <[email protected]> writes: > From: Adrian Moreno <[email protected]> > > The match keyword "igmp" is not supported in ofp-parse, which means > that flow dumps cannot be restored. Previously a workaround was > added to ovs-save to avoid changing output in stable branches. > > This patch removes that work around, and instead prints the igmp > match in the accepted format (ip,nw_proto=2). Tests are added, and > NEWS is updated to reflect this change. > > Signed-off-by: Adrian Moreno <[email protected]> > Signed-off-by: Salvatore Daniele <[email protected]> > Co-authored-by: Salvatore Daniele <[email protected]> > Acked-by: Flavio Leitner <[email protected]> > ---
It's strange to me to see a fix introduced in 1/2 and then backed out completely in 2/2. I think it makes sense not to revert it. Here's an example: Suppose I have an older ovs-vswitchd running, and I upgrade. This will replace the ovs-save script. With 1/2 and no revert from 2/2, I'll get good behavior (we will replace igmp with ip,nw_proto=2). With the current patch (revert 1/2), I will fall back into having 'igmp' in the flow output that ofp-parse cannot support. Maybe sometime in the future it might make sense to remove the replacement, but for now it helps with upgrade case. Alternatively, maybe we should add support to ofp-parse for 'igmp' keyword. Does it make sense? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
