On 7/29/21 4:24 PM, Mark Gray wrote: > On 29/07/2021 11:22, Mark Gray wrote: >> On 28/07/2021 13:14, Dumitru Ceara wrote: >>> Track amount of allocated/freed memory for each of the major memory >>> consumers in ofctrl. >>> >>> Reported-at: https://bugzilla.redhat.com/1986821 >>> Signed-off-by: Dumitru Ceara <[email protected]> >> >> This looks good to me. I think another thing we could add would be the >> memory utilization of the rconn queue. I think it would require a change >> in OVS however. I might look at that. >> > > This doesn't need a change in OVS and can be added with the following > patch. > > diff --git a/controller/ofctrl.c b/controller/ofctrl.c > index ac69d6754e9b..08fcfed8bb21 100644 > --- a/controller/ofctrl.c > +++ b/controller/ofctrl.c > @@ -2535,4 +2535,7 @@ ofctrl_get_memory_usage(struct simap *usage) > ROUND_UP(mem_stats.installed_flow_usage, 1024) / 1024); > simap_increase(usage, "oflow_update_usage-KB", > ROUND_UP(mem_stats.oflow_update_usage, 1024) / 1024); > + simap_increase(usage, "ofctrl_rconn_packet_counter-KB", > + ROUND_UP(rconn_packet_counter_n_bytes(tx_counter), 1024) > + / 1024); > } >
Looks good to me! > > Shall I modify your patch and resend? > I'm ok with that; alternatively I can send a v2 adding you as co-author. >> Acked-by: Mark D. Gray <[email protected]> >> Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
