On Wed, Jul 28, 2021 at 4:15 AM Mark Gray <[email protected]> wrote:
>
> On 27/07/2021 18:05, Lorenzo Bianconi wrote:
> > Introduce check_pkt_larger action for ingress traffic
> > entering the cluster from a distributed gw router port
> > or from a gw router. This patch enables pMTU discovery
> > for ingress traffic.
> >
> > Signed-off-by: Lorenzo Bianconi <[email protected]>
> > ---
> > northd/ovn-northd.8.xml | 60 ++++++++++++--
> > northd/ovn-northd.c | 180 +++++++++++++++++++++++-----------------
> > northd/ovn_northd.dl | 157 ++++++++++++++++++++++++++++++++---
> > tests/ovn-northd.at | 80 +++++++++++++-----
> > tests/ovn.at | 147 ++++++++++++++++++++++++++++++--
> > 5 files changed, 501 insertions(+), 123 deletions(-)
> >
> > diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml
>
> Looks good. Thanks!
>
> Acked-by: Mark D. Gray <[email protected]>
Thanks Lorenzo for this series and Mark G for the reviews.
I applied the series to the main branch.
Can you please submit a follow up patch adding a NEWS entry for this ?
I also did the below changes to the 3rd patch as the below test cases
were failing
877: ovn -- gateway mtu check pkt larger flows -- ovn-northd-ddlog --
dp-groups=yes FAILED (ovn-northd.at:4819)
878: ovn -- gateway mtu check pkt larger flows -- ovn-northd-ddlog --
dp-groups=no FAILED (ovn-northd.at:4819)
It was just an issue in ordering of actions between ovn-northd-c and
ovn-northd-ddlog.
diff --git a/northd/ovn_northd.dl b/northd/ovn_northd.dl
index 838f72824c..2cf93d61a3 100644
--- a/northd/ovn_northd.dl
+++ b/northd/ovn_northd.dl
@@ -4730,10 +4730,11 @@ for (&RouterPort(.lrp = lrp,
*/
var gw_mtu = lrp.options.get_int_def("gateway_mtu", 0) in
var mtu = gw_mtu + vLAN_ETH_HEADER_LEN() in
- var actions = "${rEG_INPORT_ETH_ADDR()} = ${lrp_networks.ea}; " ++
- if (gw_mtu > 0) {
- "${rEGBIT_PKT_LARGER()} = check_pkt_larger(${mtu}); next;"
- } else { "next;" } in {
+ var actions = if (gw_mtu > 0) {
+ "${rEGBIT_PKT_LARGER()} = check_pkt_larger(${mtu}); "
+ } else {
+ ""
+ } ++ "${rEG_INPORT_ETH_ADDR()} = ${lrp_networks.ea}; next;" in {
Flow(.logical_datapath = router._uuid,
.stage = s_ROUTER_IN_ADMISSION(),
.priority = 50,
Thanks
Numan
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
